Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fixes for cref's so that rider doesn't show red warnings #306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakejscott
Copy link
Contributor

What was changed

In Rider, when you open the solutions there's a bunch of red warning showing up for cref docs so I've updated them.

Why?

This fixes the solution wide analysis that Rider runs

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@cretz
Copy link
Member

cretz commented Jul 15, 2024

Thanks!

So there seems two issues with Rider that the .NET team and docfx don't consider issues: 1) Not requiring type arguments when not needed for overload ambiguity (why is Rider ok w/ not providing parameters in these situations but not ok w/ not providing type arguments), and 2) inability to resolve references to things in the scope they are in.

I think these are both Rider bugs if https://learn.microsoft.com/en-us/dotnet/csharp/misc/cs1574 does not warn like it does with crefs .NET/Roslyn actually can't resolve. Otherwise, these are just going to keep happening because not all contributors use this IDE and this IDE is the only one with these problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants