Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Semgrep scanning #81

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Add Semgrep scanning #81

merged 1 commit into from
Jun 6, 2023

Conversation

jackdawm
Copy link
Contributor

@jackdawm jackdawm commented Jun 1, 2023

What was changed

Adding a Semgrep scanning workflow.

Why?

To do static analysis for security vulnerabilities in our SDKs

Checklist

How was this tested:
Ran this in private repos with good results and no problems

@jackdawm jackdawm requested a review from cretz June 1, 2023 16:48
@cretz
Copy link
Member

cretz commented Jun 1, 2023

Note, semgrep will not ever fail currently if bad code is found.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the guarantee that this check will not be able to fail without discussion with the repo owners first (there are several things to consider).

@cretz cretz merged commit 4a99c2f into main Jun 6, 2023
6 checks passed
@cretz cretz deleted the semgrep branch June 6, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants