Fixes a possible panic when server resp is missing workflow type (#364)

temporalio · Feb 17, 2021 · cba4548 · cba4548
1 parent 000fce6
commit cba4548
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/internal/activity.go b/internal/activity.go
@@ -271,17 +271,17 @@ func WithActivityTask(
 
 	logger = ilog.With(logger,
 		tagActivityID, task.ActivityId,
-		tagActivityType, task.ActivityType.Name,
+		tagActivityType, task.ActivityType.GetName(),
 		tagAttempt, task.Attempt,
-		tagWorkflowType, task.WorkflowType.Name,
+		tagWorkflowType, task.WorkflowType.GetName(),
 		tagWorkflowID, task.WorkflowExecution.WorkflowId,
 		tagRunID, task.WorkflowExecution.RunId,
 	)
 
 	return context.WithValue(ctx, activityEnvContextKey, &activityEnvironment{
 		taskToken:      task.TaskToken,
 		serviceInvoker: invoker,
-		activityType:   ActivityType{Name: task.ActivityType.Name},
+		activityType:   ActivityType{Name: task.ActivityType.GetName()},
 		activityID:     task.ActivityId,
 		workflowExecution: WorkflowExecution{
 			RunID: task.WorkflowExecution.RunId,
@@ -297,7 +297,7 @@ func WithActivityTask(
 		attempt:          task.GetAttempt(),
 		heartbeatDetails: task.HeartbeatDetails,
 		workflowType: &WorkflowType{
-			Name: task.WorkflowType.Name,
+			Name: task.WorkflowType.GetName(),
 		},
 		workflowNamespace:  task.WorkflowNamespace,
 		workerStopChannel:  workerStopChannel,