Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent BuildID field name & empty TQ in intent check #1141

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Fix inconsistent BuildID field name & empty TQ in intent check #1141

merged 2 commits into from
Jun 15, 2023

Conversation

Sushisource
Copy link
Member

Two minor fixes before release

@Sushisource Sushisource requested a review from a team as a code owner June 15, 2023 22:24
bergundy
bergundy approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should have caught this empty TQ intent in tests.
Can you make sure we have coverage for the various cases? (unit tests are good enough).

@Sushisource Sushisource merged commit ae9ed7b into temporalio:master Jun 15, 2023
6 of 7 checks passed
@Sushisource Sushisource deleted the fix-id-inconsistency branch June 15, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sushisource @bergundy @Quinn-With-Two-Ns