Tag workflow_task_execution_failed with error type #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Nov 27, 2023
|
Let's make sure we're clear in release notes here so people aren't surprised when this breaks out into two metric lines in their Prometheus metrics. |
Quinn-With-Two-Ns
force-pushed
the
issue-1289
branch
from
fec8106
to
25450f8
Compare
Tag workflow_task_execution_failed with error type. Change some panics to illegal state panics so they are captured as non determinism.
Quinn-With-Two-Ns
force-pushed
the
issue-1289
branch
from
25450f8
to
1cabf54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag workflow_task_execution_failed with error type. Change some panics to illegal state panics so they are captured as non determinism.
closes #1289