Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go-grpc-middleware to v2 #1365

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update go-grpc-middleware to v2 #1365

wants to merge 1 commit into from
+29 −417

Conversation

SpencerC
Copy link

@SpencerC SpencerC commented Jan 23, 2024 •
edited

What was changed

Updated go-grpc-middleware to v2 and fixed broken APIs.

Why?

Outdated dependency.

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@SpencerC SpencerC marked this pull request as ready for review January 23, 2024 17:14
@SpencerC SpencerC requested a review from a team as a code owner January 23, 2024 17:14
@Quinn-With-Two-Ns
Copy link
Contributor

The linked issue refers to grpc_gateway not go-grpc-middleware so I am not sure how this PR is related

@SpencerC SpencerC mentioned this pull request Jan 23, 2024
Closed
@SpencerC
Copy link
Author

@Quinn-With-Two-Ns, my mistake, it isn't. 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SpencerC @CLAassistant @Quinn-With-Two-Ns