Ensure consistent labels for rpc metrics #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Apr 17, 2024
|
|
||
| // Since this interceptor can be used for clients of different name, we | ||
| // attempt to extract the namespace out of the request. All namespace-based | ||
| // requests have been confirmed to have a top-level namespace field. | ||
| namespace := "_unknown_" |
There was a problem hiding this comment.
I wonder if "_none_" is better. I have no strong opinion though, this works for me (unsure if there is an industry standard placeholder here).
There was a problem hiding this comment.
I don't know if there is a standard. I might have picked a different value myself, but this is what the server uses for the same situation so it seemed like a good idea to match
Quinn-With-Two-Ns
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Ensure that all rpc metrics have a
namespacelabel, by setting it to_unknown_if it can't be derived from the request.This was mentioned here: #861 (comment) and the resolution was to derive the
namespacelabel from the request, which is great, but it should be consistent.Why?
Many observability systems don't like the same metric to be emitted with different label sets.
Checklist
Closes
How was this tested:
updated unit test
Any docs updates needed?