Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Temporal-Namespace header on every namespace-specific gRPC request #1467

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Set Temporal-Namespace header on every namespace-specific gRPC request.

closes #1458

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner May 11, 2024 20:05
@@ -1167,6 +1168,8 @@ func (wc *WorkflowClient) loadCapabilities(ctx context.Context, getSystemInfoTim
}
ctx, cancel := context.WithTimeout(ctx, getSystemInfoTimeout)
defer cancel()
// Manually append the namespace to the header since the request does not have it.
ctx = metadata.AppendToOutgoingContext(ctx, temporalNamespaceHeaderKey, wc.namespace)
Copy link
Contributor Author

@Quinn-With-Two-Ns Quinn-With-Two-Ns May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cretz I am manually setting the namespace here here because it appears to be needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Temporal-Namespace header on every namespace-specific gRPC request
2 participants