Fix workflow panic when workflow has multiple GetVersion calls #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
I changed the logic of incrementing
nextCommandEventIDwhen processingVersionMarkerevents to support having multiple subsequentVersionMarkerevents.Why?
This fixes the issue with workflow panics on replay of a workflow that contains multiple subsequent calls to
GetVersion.Checklist
Closes Workflow replay is broken if workflow contains multiple subsequent calls to GetVersion #473
How was this tested:
Updated one of the existing replay tests to have two subsequent calls to GetVersion, without the change in
incrementNextCommandEventIDIfVersionMarkerthe test is failing.Any docs updates needed?
No