-
Notifications
You must be signed in to change notification settings - Fork 135
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support terminate-if-running reuse policy in test server (#1683)
Issue #1682
- Loading branch information
1 parent
5f5ecab
commit db81b4d
Showing
2 changed files
with
202 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
174 changes: 174 additions & 0 deletions
174
...est-server/src/test/java/io/temporal/testserver/functional/WorkflowIdReusePolicyTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,174 @@ | ||
| /* | ||
| * Copyright (C) 2022 Temporal Technologies, Inc. All Rights Reserved. | ||
| * | ||
| * Copyright (C) 2012-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Modifications copyright (C) 2017 Uber Technologies, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this material except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.temporal.testserver.functional; | ||
|
|
||
| import io.temporal.api.common.v1.WorkflowExecution; | ||
| import io.temporal.api.enums.v1.WorkflowExecutionStatus; | ||
| import io.temporal.api.enums.v1.WorkflowIdReusePolicy; | ||
| import io.temporal.api.workflowservice.v1.DescribeWorkflowExecutionRequest; | ||
| import io.temporal.client.*; | ||
| import io.temporal.failure.ApplicationFailure; | ||
| import io.temporal.testing.internal.SDKTestWorkflowRule; | ||
| import io.temporal.testserver.functional.common.TestWorkflows; | ||
| import io.temporal.workflow.Workflow; | ||
| import java.time.Duration; | ||
| import org.junit.Assert; | ||
| import org.junit.Rule; | ||
| import org.junit.Test; | ||
|
|
||
| public class WorkflowIdReusePolicyTest { | ||
|
|
||
| @Rule | ||
| public SDKTestWorkflowRule testWorkflowRule = | ||
| SDKTestWorkflowRule.newBuilder() | ||
| .setWorkflowTypes(ForeverWorkflowImpl.class, FailingWorkflowImpl.class) | ||
| .build(); | ||
|
|
||
| @Test | ||
| public void rejectDuplicateStopsAnotherAfterFailed() { | ||
| String workflowId = "reject-duplicate-1"; | ||
| WorkflowOptions options = | ||
| WorkflowOptions.newBuilder() | ||
| .setWorkflowId(workflowId) | ||
| .setWorkflowTaskTimeout(Duration.ofSeconds(1)) | ||
| .setTaskQueue(testWorkflowRule.getTaskQueue()) | ||
| .setWorkflowIdReusePolicy( | ||
| WorkflowIdReusePolicy.WORKFLOW_ID_REUSE_POLICY_REJECT_DUPLICATE) | ||
| .build(); | ||
|
|
||
| WorkflowExecution execution1 = runFailingWorkflow(options); | ||
| describe(execution1).assertStatus(WorkflowExecutionStatus.WORKFLOW_EXECUTION_STATUS_FAILED); | ||
|
|
||
| Assert.assertThrows(WorkflowExecutionAlreadyStarted.class, () -> startForeverWorkflow(options)); | ||
| } | ||
|
|
||
| @Test | ||
| public void allowDuplicateAfterFailed() { | ||
| String workflowId = "allow-duplicate-1"; | ||
| WorkflowOptions options = | ||
| WorkflowOptions.newBuilder() | ||
| .setWorkflowId(workflowId) | ||
| .setWorkflowTaskTimeout(Duration.ofSeconds(1)) | ||
| .setTaskQueue(testWorkflowRule.getTaskQueue()) | ||
| .setWorkflowIdReusePolicy( | ||
| WorkflowIdReusePolicy.WORKFLOW_ID_REUSE_POLICY_ALLOW_DUPLICATE_FAILED_ONLY) | ||
| .build(); | ||
|
|
||
| WorkflowExecution execution1 = runFailingWorkflow(options); | ||
| describe(execution1).assertStatus(WorkflowExecutionStatus.WORKFLOW_EXECUTION_STATUS_FAILED); | ||
|
|
||
| WorkflowExecution execution2 = startForeverWorkflow(options); | ||
| describe(execution2).assertStatus(WorkflowExecutionStatus.WORKFLOW_EXECUTION_STATUS_RUNNING); | ||
| } | ||
|
|
||
| @Test | ||
| public void alreadyRunningWorkflowBlocksSecondEvenWithAllowDuplicate() { | ||
| String workflowId = "allow-duplicate-2"; | ||
| WorkflowOptions options = | ||
| WorkflowOptions.newBuilder() | ||
| .setWorkflowId(workflowId) | ||
| .setWorkflowTaskTimeout(Duration.ofSeconds(1)) | ||
| .setTaskQueue(testWorkflowRule.getTaskQueue()) | ||
| .setWorkflowIdReusePolicy( | ||
| WorkflowIdReusePolicy.WORKFLOW_ID_REUSE_POLICY_ALLOW_DUPLICATE) | ||
| .build(); | ||
|
|
||
| WorkflowExecution execution1 = startForeverWorkflow(options); | ||
| describe(execution1).assertStatus(WorkflowExecutionStatus.WORKFLOW_EXECUTION_STATUS_RUNNING); | ||
|
|
||
| Assert.assertThrows(WorkflowExecutionAlreadyStarted.class, () -> startForeverWorkflow(options)); | ||
| describe(execution1).assertStatus(WorkflowExecutionStatus.WORKFLOW_EXECUTION_STATUS_RUNNING); | ||
| } | ||
|
|
||
| @Test | ||
| public void secondWorkflowTerminatesFirst() { | ||
| String workflowId = "terminate-if-running-1"; | ||
| WorkflowOptions options = | ||
| WorkflowOptions.newBuilder() | ||
| .setWorkflowId(workflowId) | ||
| .setWorkflowTaskTimeout(Duration.ofSeconds(1)) | ||
| .setTaskQueue(testWorkflowRule.getTaskQueue()) | ||
| .setWorkflowIdReusePolicy( | ||
| WorkflowIdReusePolicy.WORKFLOW_ID_REUSE_POLICY_TERMINATE_IF_RUNNING) | ||
| .build(); | ||
|
|
||
| WorkflowExecution execution1 = startForeverWorkflow(options); | ||
| describe(execution1).assertStatus(WorkflowExecutionStatus.WORKFLOW_EXECUTION_STATUS_RUNNING); | ||
|
|
||
| WorkflowExecution execution2 = startForeverWorkflow(options); | ||
| describe(execution1).assertStatus(WorkflowExecutionStatus.WORKFLOW_EXECUTION_STATUS_TERMINATED); | ||
| describe(execution2).assertStatus(WorkflowExecutionStatus.WORKFLOW_EXECUTION_STATUS_RUNNING); | ||
| } | ||
|
|
||
| private WorkflowExecution startForeverWorkflow(WorkflowOptions options) { | ||
| TestWorkflows.PrimitiveWorkflow workflowStub = | ||
| testWorkflowRule | ||
| .getWorkflowClient() | ||
| .newWorkflowStub(TestWorkflows.PrimitiveWorkflow.class, options); | ||
| WorkflowClient.start(workflowStub::execute); | ||
| return WorkflowStub.fromTyped(workflowStub).getExecution(); | ||
| } | ||
|
|
||
| private WorkflowExecution runFailingWorkflow(WorkflowOptions options) { | ||
| TestWorkflows.WorkflowReturnsString workflowStub = | ||
| testWorkflowRule | ||
| .getWorkflowClient() | ||
| .newWorkflowStub(TestWorkflows.WorkflowReturnsString.class, options); | ||
| Assert.assertThrows(WorkflowFailedException.class, workflowStub::execute); | ||
| return WorkflowStub.fromTyped(workflowStub).getExecution(); | ||
| } | ||
|
|
||
| private DescribeWorkflowAsserter describe(WorkflowExecution execution) { | ||
| DescribeWorkflowAsserter result = | ||
| new DescribeWorkflowAsserter( | ||
| testWorkflowRule | ||
| .getWorkflowClient() | ||
| .getWorkflowServiceStubs() | ||
| .blockingStub() | ||
| .describeWorkflowExecution( | ||
| DescribeWorkflowExecutionRequest.newBuilder() | ||
| .setNamespace( | ||
| testWorkflowRule.getWorkflowClient().getOptions().getNamespace()) | ||
| .setExecution(execution) | ||
| .build())); | ||
|
|
||
| // There are some assertions that we can always make... | ||
| return result | ||
| .assertExecutionId(execution) | ||
| .assertSaneTimestamps() | ||
| .assertTaskQueue(testWorkflowRule.getTaskQueue()); | ||
| } | ||
|
|
||
| public static class ForeverWorkflowImpl implements TestWorkflows.PrimitiveWorkflow { | ||
| @Override | ||
| public void execute() { | ||
| // wait forever to keep it in running state | ||
| Workflow.await(() -> false); | ||
| } | ||
| } | ||
|
|
||
| public static class FailingWorkflowImpl implements TestWorkflows.WorkflowReturnsString { | ||
| @Override | ||
| public String execute() { | ||
| throw ApplicationFailure.newNonRetryableFailure("It's done", "someFailure"); | ||
| } | ||
| } | ||
| } |