Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header support for signals and queries #940

Closed
cretz opened this issue Dec 28, 2021 · 4 comments
Closed

Header support for signals and queries #940

cretz opened this issue Dec 28, 2021 · 4 comments
Labels
enhancement User experience

Comments

@cretz
Copy link
Member

cretz commented Dec 28, 2021

Is your feature request related to a problem? Please describe.

Headers were added to signals and queries in temporalio/temporal#2149.

Describe the solution you'd like

Add to SDK

Additional context
@cretz cretz added the enhancement User experience label Dec 28, 2021
@cretz cretz mentioned this issue Dec 28, 2021
Closed
@pooja-fyndna
Copy link

I am also waiting for this feature. Any updates on this?

@Spikhalskiy
Copy link
Contributor

Spikhalskiy commented Mar 2, 2023 •
edited
Loading

@pooja-fyndna There is no updates. If there was work done - there would be linked PRs.
We don’t provide time estimates for feature requests.
We happily accept contributions.

@bhagya05
Copy link

@Spikhalskiy We are extending WorkflowClientCallsInterceptorBase and OpenTracingWorkflowInboundCallsInterceptor
to add tracing for signal in temporal 1.25.1 java sdk.
Is this a valid approach ?

@Quinn-With-Two-Ns
Copy link
Contributor

This issue was already resolved by #1819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement User experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cretz @Spikhalskiy @Quinn-With-Two-Ns @bhagya05 @pooja-fyndna