Activity APIs cleanup. #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarabbas
reviewed
Jun 22, 2020
| */ | ||
| public interface ActivityCompletionClient { | ||
|
|
||
| <R> void complete(byte[] taskToken, R result) throws ActivityCompletionException; | ||
|
|
||
| <R> void complete(WorkflowExecution execution, String activityId, R result) | ||
| <R> void complete(String workflowId, Optional<String> runId, String activityId, R result) |
There was a problem hiding this comment.
It feels weird to have optional parameter in the middle of signature. It is considered very bad practice to have required parameters after optional ones.
samarabbas
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes ActivityExecutionContext to simplify passing activity info around to other threads. Removed redundant methods from Activity class. Also some renaming for consistency. Changed some getters to return Optional instead of null.
Also fixes #98