-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added thread interceptor #120
Conversation
WorkflowThread newThread(Runnable runnable, boolean detached, String name); | ||
|
||
/** Only to be called by SyncDecisionContext. */ | ||
WorkflowThread newThreadNoInterceptor(Runnable runnable, boolean detached, String name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to understand why this additional API is needed? Why can't there be a no-op interceptor which does nothing. It would be good to provide some context as part of API documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored to remove the need for newThreadNoInterceptor.
Added WorkflowInterceptor support for workflow threads. It is to allow support for context propagation without modifying the SDK code directly.