Spring Boot 3 support #1620
Spring Boot 3 support #1620
Conversation
Spikhalskiy
force-pushed
the
issue-1619
branch
5 times, most recently
from
0c252f8
to
54a71f5
Compare
Spikhalskiy
requested review from
mfateev,
Sushisource,
cretz,
bergundy and
mmcshane
as code owners
Spikhalskiy
force-pushed
the
issue-1619
branch
5 times, most recently
from
c024519
to
11fd20c
Compare
| @@ -3,7 +3,7 @@ steps: | |||
| agents: | |||
| queue: "default" | |||
| docker: "*" | |||
| command: "./gradlew --no-daemon test -x checkLicenseMain -x checkLicenses -x spotlessCheck -x spotlessApply -x spotlessJava" | |||
| command: "./gradlew --no-daemon test -x checkLicenseMain -x checkLicenses -x spotlessCheck -x spotlessApply -x spotlessJava -P edgeDepsTest" | |||
There was a problem hiding this comment.
By only adding -P edgeDepsTest here and not the other test below, does this also kinda serve as a way to test with and without these deps?
When we move to GH actions, I think a matrix of Java versions (probably just 8 and latest which the GH action probably supports...it's 19 atm I think) and test servers would make sense. That's what we do in Python (multi version, multi platform, multi server type). There may not be much value in testing different platforms for Java though.
There was a problem hiding this comment.
Yeah, I kinda use "test environment" based config as an "edge" already by putting it on java 18. Now it also uses the new dependencies. "Test server" is a "legacy" environment on java8 and uses the deps that we pack in the release.
Honestly, I don't think a lot of reasons to do a fair matrix here yet.
SDK either works correctly on old/new Java or not. Also, if something breaks on java 11, it will be broken on java 17. So covering the edges is typically enough.
"Edge" dependencies added here only work on new JDKs (Spring Boot 3 requires Java 17 for example).
But we can add [java 8,11,17 : test,real server] matrix to master merges to be sure in (java17;real server) coverage for example.
Spikhalskiy
force-pushed
the
issue-1619
branch
from
11fd20c
to
373fd06
Compare
Fix incompatibilities with Sprint Boot 3.
Add
edgeDepsTestprofile that is going to use the latest dependencies versions for compatibility testing.Closes #1619