Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rare deadlock when event loop is triggered after a main thread threw an exception #1690

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

Spikhalskiy
Copy link
Contributor

What was changed

With this PR, Workflow Threads will never block waiting for the closure of the DeterministicRunner. Because the closure procedure itself waits on the Workflow Threads to complete.

Why?

Closes #871

@Spikhalskiy Spikhalskiy marked this pull request as ready for review March 7, 2023 07:37
@Spikhalskiy Spikhalskiy requested a review from a team as a code owner March 7, 2023 07:37
@Spikhalskiy Spikhalskiy merged commit 7521f85 into temporalio:master Mar 7, 2023
@Spikhalskiy Spikhalskiy deleted the issue-871 branch March 7, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deadlock during activity state machine cancelation
2 participants