Release WF slot on UnableToAcquireLockException #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -189,7 +189,7 @@ public void concurrentPollRequestLockTest() throws Exception { | |||
| ImmutableMap.of("worker_type", "WorkflowWorker"), | |||
| 100.0); | |||
| // Cleanup | |||
| worker.shutdown(new ShutdownManager(), true).get(); | |||
| worker.shutdown(new ShutdownManager(), false).get(); | |||
There was a problem hiding this comment.
using false here lets us test the change works
cretz
approved these changes
Sep 26, 2023
cretz
approved these changes
Sep 26, 2023
Quinn-With-Two-Ns
added a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user noticed that if their workflow task failed with
UnableToAcquireLockExceptiontheir worker would not be able to shutdown. Root cause was onUnableToAcquireLockExceptionwe didn't calltask.getCompletionCallback().apply();because the exception was outside thefinallyblock.Note: this will change the timing of
WORKFLOW_TASK_EXECUTION_TOTAL_LATENCYto include the time waiting for the run lock, but this metric is java specific and is undocumented, and arguably should include the run lock.close #1870