Add getWorkerTaskReachability API #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Nov 1, 2023
| * the value is an empty list, the Build ID is not reachable on that queue. | ||
| */ | ||
| public Map<String, List<TaskReachability>> getTaskQueueReachability() { | ||
| return Collections.unmodifiableMap(taskQueueReachability); |
There was a problem hiding this comment.
I think this should be done in the constructor or by the constructor's caller (same with unmodifiable list below)
There was a problem hiding this comment.
I would prefer it to be here then in the constructor or trust the caller to have used the correct type
There was a problem hiding this comment.
I see this is already merged, but curious why not the constructor? Why create a new object every time a getter is called if you don't need to?
temporal-sdk/src/main/java/io/temporal/client/BuildIdReachability.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/client/WorkerTaskReachability.java
Outdated
Show resolved
Hide resolved
Sushisource
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add getWorkerTaskReachability API
closes #1862