Unwrap ExecutionException on sync update #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jan 22, 2024
Comment on lines
+56
to
+57
| assertThrows( | ||
| WorkflowUpdateException.class, |
There was a problem hiding this comment.
Can you verify the cause here is the serialized application failure? (or confirm a test elsewhere confirms the proper thrown exception type from update)
There was a problem hiding this comment.
Yes we have lots of other tests that verify the exception type from an update
There was a problem hiding this comment.
👍 I would have expected them to also confirm/deny WorkflowUpdateException was the properly thrown exception, but I am guessing they just validated the cause not the top-level type?
cretz
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unwrap ExecutionException on sync update. We shouldn't return the
ExecutionExceptionto caller since they aren't expecting an ExecutionException on a sync update.closes #1973