Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support newer JSON history format #2001

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Support newer JSON history format #2001

merged 1 commit into from
Mar 5, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Mar 4, 2024

What was changed

  • Changed WorkflowExecutionHistory.fromJson to support proper protobuf JSON fields
  • Changed existing WorkflowExecutionHistory.toJson method to emit proper protobuf JSON fields
    • 馃挜 Please make a note in release notes that this default behavior changed
  • Added WorkflowExecutionHistory.toJson overload that lets you specify legacy format boolean to emit it the way it used to

@cretz cretz requested a review from a team as a code owner March 4, 2024 20:37
@cretz cretz merged commit 0e4ef15 into temporalio:master Mar 5, 2024
6 checks passed
@cretz cretz deleted the history-new-style branch March 5, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cretz @Quinn-With-Two-Ns