Return supported query types for unsupported queries #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitarb
reviewed
Feb 23, 2021
temporal-sdk/src/test/java/io/temporal/internal/sync/QueryDispatcherTest.java
Outdated
Show resolved
Hide resolved
vitarb
reviewed
Feb 23, 2021
temporal-sdk/src/test/java/io/temporal/internal/sync/QueryDispatcherTest.java
Show resolved
Hide resolved
vitarb
reviewed
Feb 23, 2021
temporal-sdk/src/test/java/io/temporal/internal/sync/QueryDispatcherTest.java
Outdated
Show resolved
Hide resolved
vitarb
reviewed
Feb 25, 2021
vitarb
reviewed
Feb 25, 2021
temporal-sdk/src/test/java/io/temporal/internal/sync/QueryDispatcherTest.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/test/java/io/temporal/internal/sync/QueryDispatcherTest.java
Outdated
Show resolved
Hide resolved
added 3 commits
February 25, 2021 15:50
…sdk-java into return-supported-query-types
vitarb
approved these changes
Feb 26, 2021
| @@ -75,7 +75,8 @@ public void setInboundCallsInterceptor(WorkflowInboundCallsInterceptor inboundCa | |||
| Object[] args; | |||
| if (handler == null) { | |||
| if (dynamicQueryHandler == null) { | |||
| throw new IllegalStateException("Unknown query type: " + queryName); | |||
| throw new IllegalArgumentException( | |||
| "Unknown query type: " + queryName + ", knownTypes=" + queryCallbacks.keySet()); | |||
There was a problem hiding this comment.
could you comment a sample string of this output? I want to test with the web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error: Query workflow failed.
Error Details: rpc error: code = InvalidArgument desc = java.lang.IllegalArgumentException: Unknown query type: queryGreeting123, knownTypes=[queryGreeting]