GrpcRetryer now retries underlying DEADLINE_EXCEEDED if the root gRPC context deadline is not expired #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
mfateev,
Sushisource and
vitarb
as code owners
Spikhalskiy
force-pushed
the
issue-708
branch
3 times, most recently
from
51f8a67
to
75b932f
Compare
… context deadline is not expired Issue temporalio#708
Sushisource
approved these changes
Sep 11, 2021
temporal-serviceclient/src/main/java/io/temporal/internal/retryer/GrpcRetryerUtils.java
Outdated
Show resolved
Hide resolved
Comment on lines
+460
to
+461
| Preconditions.checkArgument( | ||
| timeout.toMillis() > 70_000, "rpcLongPollTimeout has to be longer 70s"); |
There was a problem hiding this comment.
Since we're already deprecating here I dunno that we need to potentially cause people pain by throwing here if they're already setting it too low.
I can go either way here though so if you want to keep it go for it.
There was a problem hiding this comment.
Setting less than 70s here now is just dangerous. So, I think it's the best we can do here.
…yer/GrpcRetryerUtils.java Co-authored-by: Spencer Judge <sjudge@hey.com>
mfateev
approved these changes
Sep 11, 2021
This was referenced Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
GrpcRetryernow retries underlyingDEADLINE_EXCEEDEDif the root gRPC context deadline is not expiredWhy?
The behavior of
GrpcRetryerhas been changed in java-sdk#1.3.0 that causes potential regressions whenGrpcRetryeris used withDeadlineGrpcInterceptorlike described in #708Closes #708