Merge pull request #468: add ProtoBinary decoder in default set

src/DataConverter/DataConverter.php

@@ -87,6 +87,7 @@ public static function createDefault(): DataConverterInterface
             new NullConverter(),
             new BinaryConverter(),
             new ProtoJsonConverter(),
+            new ProtoConverter(),
             new JsonConverter()
         );
     }

tests/Unit/DataConverter/DataConverterTestCase.php

@@ -14,8 +14,12 @@
 use PHPUnit\Framework\Attributes\DataProvider;
 use Temporal\DataConverter\DataConverter;
 use Temporal\DataConverter\DataConverterInterface;
+use Temporal\DataConverter\EncodingKeys;
+use Temporal\DataConverter\ProtoConverter;
+use Temporal\DataConverter\ProtoJsonConverter;
 use Temporal\DataConverter\Type;
 use Temporal\Exception\DataConverterException;
+use Temporal\Tests\Proto\Test;
 use Temporal\Tests\Unit\AbstractUnit;
 
 /**
@@ -177,4 +181,28 @@ public function testNullableTypeCoercion(string $type, $value): void
 
         $this->assertNull($converter->fromPayload($payload, $type));
     }
+
+    /**
+     * DataConverter may decode protobuf binary messages
+     */
+    public function testProtobufBinaryDecoding(): void
+    {
+        $message = (new Test())->setValue('foo');
+        $payload = (new ProtoConverter())->toPayload($message);
+
+        $decoded = DataConverter::createDefault()->fromPayload($payload, Test::class);
+
+        self::assertEquals($message, $decoded);
+    }
+
+    /**
+     * DataConverter decodes Protobuf messages using ProtoJson converter
+     */
+    public function testProtobufEncodingToJson(): void
+    {
+        $message = (new Test())->setValue('foo');
+        $payload = DataConverter::createDefault()->toPayload($message);
+
+        self::assertSame(EncodingKeys::METADATA_ENCODING_PROTOBUF_JSON, $payload->getMetadata()['encoding']);
+    }
 }