Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose defaultConnection() method to switch between localhost and cloud based on env #420

Open
josh-berry opened this issue Apr 12, 2024 · 1 comment · May be fixed by #422
Open

Expose defaultConnection() method to switch between localhost and cloud based on env #420

josh-berry opened this issue Apr 12, 2024 · 1 comment · May be fixed by #422

Comments

@josh-berry
Copy link

josh-berry commented Apr 12, 2024 •
edited

Expose a defaultConnection() method or similar that switches between localhost (default) and cloud based on some environment variable, so that we can use it in the samples repos to allow people to easily run samples in the cloud. See: temporalio/features#454
@josh-berry josh-berry mentioned this issue Apr 12, 2024
Open
13 tasks
@roxblnfk
Copy link
Collaborator

We use TEMPORAL_ADDRESS env in our temporal-bridge

https://github.com/spiral/temporal-bridge/blob/38be446ffe9feae7ba26fe5d22876b7786fe08f7/src/Bootloader/TemporalBridgeBootloader.php#L124

@roxblnfk roxblnfk linked a pull request Apr 16, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create a service connection depending on ENVs temporalio/sdk-php
2 participants
@josh-berry @roxblnfk