Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a service connection depending on ENVs #422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create a service connection depending on ENVs #422

wants to merge 1 commit into from

Conversation

roxblnfk
Copy link
Collaborator

What was changed

Added ServiceClient::createDefaultConnection() method that creates a new connection with settings from environment variables.

Checklist

  1. Closes Expose defaultConnection() method to switch between localhost and cloud based on env #420
  2. Tests
  3. Docs
  4. Sync with RoadRunner

@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 7:32pm

@roxblnfk
Copy link
Collaborator Author

@Sushisource could you validate this approach?

@roxblnfk roxblnfk marked this pull request as ready for review April 23, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Awaiting requested review from Sushisource

@wolfy-j wolfy-j Awaiting requested review from wolfy-j

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose defaultConnection() method to switch between localhost and cloud based on env
1 participant
@roxblnfk