Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass named functions arguments in correct order and with default values #376

Merged
merged 24 commits into from
Feb 5, 2024

Conversation

shanginn
Copy link
Contributor

@shanginn shanginn commented Dec 3, 2023

What was changed

Allow for named arguments in workflow handler, signals and activities params

Why?

Because it's possible in PHP

Checklist

  1. Closes Issue 282

  2. Tested in NamedArgumentsTestCase

@roxblnfk roxblnfk self-requested a review December 4, 2023 06:37
@roxblnfk roxblnfk modified the milestone: 2.7.0 Dec 4, 2023
@roxblnfk
Copy link
Collaborator

Hello. Thank you for your contribution to the Temporal PHP SDK.
I've done an initial review and made some edits. However, there's still a lot of work to be done. Please note that there is an opportunity to create different stubs (like ChildWorkflow) through the Workflow:: facade. We need to ensure that named arguments also work in such a flow.

@roxblnfk
Copy link
Collaborator

Need to fix arguments sorter. See the new unit tests

Copy link
Collaborator

@roxblnfk roxblnfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@shanginn need to fix psalm issues

@roxblnfk roxblnfk requested a review from wolfy-j January 30, 2024 13:36
@wolfy-j
Copy link
Collaborator

wolfy-j commented Feb 5, 2024

LGTM

@roxblnfk roxblnfk merged commit e726dda into temporalio:master Feb 5, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] PHP 8 named arguments don't work
4 participants