-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass named functions arguments in correct order and with default values #376
Pass named functions arguments in correct order and with default values #376
Conversation
Hello. Thank you for your contribution to the Temporal PHP SDK. |
ce242e1
to
92b0df3
Compare
Need to fix arguments sorter. See the new unit tests |
…ed and indexed) and handle more args than expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@shanginn need to fix psalm issues
5dcd6a4
to
fb0b3e9
Compare
LGTM |
What was changed
Allow for named arguments in workflow handler, signals and activities params
Why?
Because it's possible in PHP
Checklist
Closes Issue 282
Tested in NamedArgumentsTestCase