Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] with_child_unrestricted not properly removing restriction #254

Closed
cretz opened this issue Jan 13, 2023 · 0 comments · Fixed by #268
Closed

[Bug] with_child_unrestricted not properly removing restriction #254

cretz opened this issue Jan 13, 2023 · 0 comments · Fixed by #268
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented Jan 13, 2023

Describe the bug

sdk-python/temporalio/worker/workflow_sandbox/_restrictions.py

Line 311 in ddbb92f

if child_path in self.children:

Should be:

if child_path[0] in self.children:
@cretz cretz added the bug Something isn't working label Jan 13, 2023
cretz added a commit to cretz/temporal-sdk-python that referenced this issue Feb 7, 2023
@cretz
Fix for with_child_unrestricted
cd8c62f 
Fixes temporalio#254
@cretz cretz mentioned this issue Feb 7, 2023
Merged
@cretz cretz closed this as completed in #268 Feb 8, 2023
cretz added a commit that referenced this issue Feb 8, 2023
@cretz
Minor fixes (#268)
3c8ee0a 
Fixes #254
Fixes #263
@gregbrowndev gregbrowndev mentioned this issue Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor fixes cretz/temporal-sdk-python
1 participant
@cretz