Rename sdk-features to features" #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2b4eed8.
|
|
cretz
approved these changes
Jan 10, 2023
|
@cretz CI seems unstable, I've had 3 consecutive unrelated failures. |
|
This is failing on the time-skipping test server in CI (note the arm builds passed) so I suspect it's due to new RC release. For some reason it got an activity timeout immediately which makes me concerned that the test server isn't properly shutting off time skipping during activity invocation anymore? Or some other bug. I have restarted CI since you've pinned the test server back to an older version and it works now. We need to make sure that we run this Python test with the test server before unpinning/upgrading it on the CDN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on temporalio/features#207