Keep extra log attributes (fixes #276) #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cretz
approved these changes
Feb 15, 2023
|
There is an issue w/ latest Python static linking. Unrelated to this PR, but I will have to fix it first then I'll get back to this. |
|
Thanks for merging @cretz! When can we expect a release with these fixes? |
|
After scheduling and a few other fixes. No exact timeline but hopefully soon. You can build any time or just download the built wheel artifacts off the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Fix for #276, removing the calls to
super().process(...)so that we do not overwrite the extra attributes for the log record.Why?
So that we can properly support structured logging with extra attributes
Checklist