Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update last cleanup items #410

Merged
merged 2 commits into from Oct 30, 2023
Merged

Update last cleanup items #410

merged 2 commits into from Oct 30, 2023

Conversation

Sushisource
Copy link
Member

What was changed

Remove poll update interceptor & timeout on result

Why?

Per discussed changes

Checklist

  1. Closes Remove OutboundInterceptor.poll_workflow_update #409 and closes Remove timeout from WorkflowUpdateHandle.result #408
  2. How was this tested:
  1. Any docs updates needed?

@Sushisource Sushisource requested a review from a team as a code owner October 30, 2023 17:08
@Sushisource Sushisource enabled auto-merge (squash) October 30, 2023 17:30
@Sushisource Sushisource merged commit fd938c4 into main Oct 30, 2023
12 checks passed
@Sushisource Sushisource deleted the update-cleanup branch October 30, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove OutboundInterceptor.poll_workflow_update Remove timeout from WorkflowUpdateHandle.result
2 participants
@Sushisource @cretz