Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in upsert search attribs #440

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Fix bugs in upsert search attribs #440

merged 2 commits into from
Nov 30, 2023

Conversation

Sushisource
Copy link
Member

@Sushisource Sushisource commented Nov 29, 2023 •
edited
Loading

What was changed

Fixed some bugs in search attrib upsert that occur if the workflow has no initial search attribs

Why?

Bugs bad

Checklist

  1. Closes

  2. How was this tested:
    Added simple test

  3. Any docs updates needed?

@Sushisource Sushisource requested a review from a team as a code owner November 29, 2023 23:42
cretz
cretz approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Sushisource Sushisource merged commit 6f966c7 into main Nov 30, 2023
12 checks passed
@Sushisource Sushisource deleted the fix-sa-upsert branch November 30, 2023 17:46
@Sushisource Sushisource mentioned this pull request Dec 1, 2023
Merged
@cretz cretz mentioned this pull request Dec 11, 2023
Closed
@ndtretyak ndtretyak mentioned this pull request Dec 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sushisource @cretz