Support float and duration metrics #508
Conversation
| """Initialize histogram.""" | ||
| self._ref = meter._ref.new_histogram_duration(name, description, unit) | ||
|
|
||
| def record(self, value_ms: int, attrs: MetricAttributes) -> None: |
There was a problem hiding this comment.
Why not pass through timedelta here too?
There was a problem hiding this comment.
It's not the most trivial to create these types of objects on the Rust side and there's a cost to creating them on the Rust side (have to capture GIL, etc). I considered converting back to timedelta closer to the user (and I do it in .NET), but I would have to decide whether to create it on the Rust side or Python side (today each getter of a Python buffered metric value is actually backed by Rust values which is neat). The Rust side is a pain, and the Python side is expensive and unnecessary since the user can do it themselves.
But I have left open this possibility. I have an enum of MetricBufferDurationFormat and if we want to add a third TIMEDELTA enum we can (like we did in .NET).
There was a problem hiding this comment.
K, that's reasonable. Being able to record them as timedeltas is the main thing that matters and that works.
What was changed
MetricMeter.create_histogram_float,MetricMeter.create_histogram_timedelta, andMetricMeter.create_gauge_floatduration_formatonMetricBuffercreate. It defaults to milliseconds, but can be set to secondsChecklist