fix(client): Fix incorrect schedule spec boundaries #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjameswh
changed the title
bergundy
reviewed
May 25, 2023
| @@ -497,6 +497,7 @@ export class ScheduleClient extends BaseClient { | |||
| } | |||
|
|
|||
| protected rethrowGrpcError(err: unknown, scheduleId: string, fallbackMessage: string): never { | |||
| if (err instanceof TypeError) throw err; | |||
There was a problem hiding this comment.
Hmm.. wondering if we can catch the type error at a different level.
There was a problem hiding this comment.
We could, but then we would need that extra check in every function that does encodings. Not a big thing, but that's why I put it there.
There was a problem hiding this comment.
Just find it a bit out of place here.
I’ll let you make the call.
bergundy
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Fix incorrect schedule spec boundaries validation on hour and day-of-month fields
Why
CalendarSpeccomponents not encoded correctly #1105