Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(workflow): Fix isReplaying being incorrectly true due to query #1211

Merged
merged 2 commits into from
Aug 22, 2023
Merged

fix(workflow): Fix isReplaying being incorrectly true due to query #1211

merged 2 commits into from
Aug 22, 2023

Conversation

mjameswh
Copy link
Contributor

@mjameswh mjameswh commented Aug 22, 2023 •
edited

What was changed

Why

  • This could notably cause situations where calls to sink functions not configured with calledDuringReplay = true would not be relayed, as well as situations where patched(...) would return false even though this part of the code was being executed for the first time.

@mjameswh mjameswh requested a review from a team as a code owner August 22, 2023 16:09
@mjameswh mjameswh merged commit 51c513a into temporalio:main Aug 22, 2023
24 of 25 checks passed
@mjameswh mjameswh deleted the update-core branch August 22, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjameswh @Sushisource