Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support bundling Workflow code prior to Worker creation #336

Merged
merged 1 commit into from
Oct 26, 2021
Merged

feat: Support bundling Workflow code prior to Worker creation #336

merged 1 commit into from
Oct 26, 2021

Conversation

bergundy
Copy link
Member

Closes #310

swyxio
swyxio approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@swyxio swyxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gave roey some thoughts on validating the bundle and printing a nice error - in practice i think this will be ok provided we also make a sample for this :)

@swyxio swyxio mentioned this pull request Oct 26, 2021
Closed
@bergundy bergundy merged commit 6f20113 into main Oct 26, 2021
@bergundy bergundy deleted the separate-bundle-and-worker-create branch October 26, 2021 04:11
@bergundy
Copy link
Member Author

We should definitely mention this in the deployment docs (when I write that page) and add a sample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swyxio swyxio swyxio approved these changes

@Sushisource Sushisource Awaiting requested review from Sushisource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support separating bundling and executing of workers
2 participants
@bergundy @swyxio