Skip to content

Commit

Permalink
Implement AdminService.GetDLQTasks (#4884)
Browse files Browse the repository at this point in the history
<!-- Describe what has changed in this PR -->
**What changed?**
I added `AdminService.GetDLQTasks`, and I implemented it in the
`AdminHandler`.

<!-- Tell your future self why have you made these changes -->
**Why?**
We want to copy these APIs to the admin service so that we can use them
from tdbg.

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
I added a unit test which covers 100% of the new code.

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
The fact that this code is literally copy-pasting all the protos from
the history service means that we will end up with a lot of redundant
code that does nothing but replace `historyservice` with `adminservice`
and vise-versa.

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
  • Loading branch information
MichaelSnowden committed Sep 29, 2023
1 parent dc1b4ee commit 0a94c38
Show file tree
Hide file tree
Showing 10 changed files with 2,339 additions and 358 deletions.
2,310 changes: 2,013 additions & 297 deletions api/adminservice/v1/request_response.pb.go

Large diffs are not rendered by default.

157 changes: 97 additions & 60 deletions api/adminservice/v1/service.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 35 additions & 0 deletions api/adminservicemock/v1/service.pb.mock.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions client/admin/client_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions client/admin/metric_client_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions client/admin/retryable_client_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0a94c38

Please sign in to comment.