-
Notifications
You must be signed in to change notification settings - Fork 747
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support visibility dual write to different ES indices (#2359)
* Change order by clauses in query and update V1 index template. Index created by the old template will continue to function, but won't see the query performance improvement. * Support visibility dual write to different ES indices. * Add additional dynamic configs to control visibility dual write behavior.
- Loading branch information
1 parent
1a3cf49
commit 319861d
Showing
17 changed files
with
280 additions
and
128 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| // The MIT License | ||
| // | ||
| // Copyright (c) 2020 Temporal Technologies Inc. All rights reserved. | ||
| // | ||
| // Copyright (c) 2020 Uber Technologies, Inc. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| package visibility | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "go.temporal.io/api/serviceerror" | ||
| "go.temporal.io/server/common/dynamicconfig" | ||
| "go.temporal.io/server/common/namespace" | ||
| "go.temporal.io/server/common/persistence/visibility/manager" | ||
| ) | ||
|
|
||
| type ( | ||
| managerSelector interface { | ||
| readManager(namespace namespace.Name) manager.VisibilityManager | ||
| writeManagers() ([]manager.VisibilityManager, error) | ||
| } | ||
|
|
||
| sqlToESManagerSelector struct { | ||
| enableAdvancedVisibilityRead dynamicconfig.BoolPropertyFnWithNamespaceFilter | ||
| advancedVisibilityWritingMode dynamicconfig.StringPropertyFn | ||
| stdVisibilityManager manager.VisibilityManager | ||
| advVisibilityManager manager.VisibilityManager | ||
| } | ||
|
|
||
| esManagerSelector struct { | ||
| enableReadFromSecondaryVisibility dynamicconfig.BoolPropertyFnWithNamespaceFilter | ||
| enableWriteToSecondaryVisibility dynamicconfig.BoolPropertyFn | ||
| visibilityManager manager.VisibilityManager | ||
| secondaryVisibilityManager manager.VisibilityManager | ||
| } | ||
| ) | ||
|
|
||
| var _ managerSelector = (*sqlToESManagerSelector)(nil) | ||
| var _ managerSelector = (*esManagerSelector)(nil) | ||
|
|
||
| func NewSQLToESManagerSelector( | ||
| stdVisibilityManager manager.VisibilityManager, | ||
| advVisibilityManager manager.VisibilityManager, | ||
| enableAdvancedVisibilityRead dynamicconfig.BoolPropertyFnWithNamespaceFilter, | ||
| advancedVisibilityWritingMode dynamicconfig.StringPropertyFn, | ||
| ) *sqlToESManagerSelector { | ||
| return &sqlToESManagerSelector{ | ||
| stdVisibilityManager: stdVisibilityManager, | ||
| advVisibilityManager: advVisibilityManager, | ||
| enableAdvancedVisibilityRead: enableAdvancedVisibilityRead, | ||
| advancedVisibilityWritingMode: advancedVisibilityWritingMode, | ||
| } | ||
| } | ||
|
|
||
| func NewESManagerSelector( | ||
| visibilityManager manager.VisibilityManager, | ||
| secondaryVisibilityManager manager.VisibilityManager, | ||
| enableReadFromSecondaryVisibility dynamicconfig.BoolPropertyFnWithNamespaceFilter, | ||
| enableWriteToSecondaryVisibility dynamicconfig.BoolPropertyFn, | ||
| ) *esManagerSelector { | ||
| return &esManagerSelector{ | ||
| visibilityManager: visibilityManager, | ||
| secondaryVisibilityManager: secondaryVisibilityManager, | ||
| enableReadFromSecondaryVisibility: enableReadFromSecondaryVisibility, | ||
| enableWriteToSecondaryVisibility: enableWriteToSecondaryVisibility, | ||
| } | ||
| } | ||
|
|
||
| func (v *sqlToESManagerSelector) writeManagers() ([]manager.VisibilityManager, error) { | ||
| switch v.advancedVisibilityWritingMode() { | ||
| case AdvancedVisibilityWritingModeOff: | ||
| return []manager.VisibilityManager{v.stdVisibilityManager}, nil | ||
| case AdvancedVisibilityWritingModeOn: | ||
| return []manager.VisibilityManager{v.advVisibilityManager}, nil | ||
| case AdvancedVisibilityWritingModeDual: | ||
| return []manager.VisibilityManager{v.stdVisibilityManager, v.advVisibilityManager}, nil | ||
| default: | ||
| return nil, serviceerror.NewInternal(fmt.Sprintf("Unknown advanced visibility writing mode: %s", v.advancedVisibilityWritingMode())) | ||
| } | ||
| } | ||
|
|
||
| func (v *sqlToESManagerSelector) readManager(namespace namespace.Name) manager.VisibilityManager { | ||
| if v.enableAdvancedVisibilityRead(namespace.String()) { | ||
| return v.advVisibilityManager | ||
| } | ||
| return v.stdVisibilityManager | ||
| } | ||
|
|
||
| func (v *esManagerSelector) writeManagers() ([]manager.VisibilityManager, error) { | ||
| managers := []manager.VisibilityManager{v.visibilityManager} | ||
| if v.enableWriteToSecondaryVisibility() { | ||
| managers = append(managers, v.secondaryVisibilityManager) | ||
| } | ||
|
|
||
| return managers, nil | ||
| } | ||
|
|
||
| func (v *esManagerSelector) readManager(namespace namespace.Name) manager.VisibilityManager { | ||
| if v.enableReadFromSecondaryVisibility(namespace.String()) { | ||
| return v.secondaryVisibilityManager | ||
| } | ||
| return v.visibilityManager | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.