Skip to content

Commit

Permalink
Replace tctl with cli in CONTRIBUTING.md and Makefile
Browse files Browse the repository at this point in the history
We're deprecating tctl in v1.22
  • Loading branch information
ShahabT committed Aug 23, 2023
1 parent b16758e commit 31a87d9
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
Expand Up @@ -12,10 +12,10 @@ This doc is for contributors to Temporal Server (hopefully that's you!)
* [Protocol buffers compiler](https://github.com/protocolbuffers/protobuf/) (only if you are going to change `proto` files):
- Install on macOS with `brew install protobuf`.
- Download all other versions from [protoc release page](https://github.com/protocolbuffers/protobuf/releases).
* [Temporal CLI tctl](https://github.com/temporalio/tctl)
- Homebrew `brew install tctl`
- Go install `make update-tctl`
- Or download it from here https://github.com/temporalio/tctl
* [Temporal CLI](https://github.com/temporalio/cli)
- Homebrew `brew install temporal`
- Go install `make update-cli`
- Or download it from here https://github.com/temporalio/cli


### Runtime (server and tests) prerequisites
Expand Down Expand Up @@ -116,7 +116,7 @@ make start

Now you can create default namespace with `tctl`:
```bash
tctl --namespace default namespace register
temporal operator namespace create default
```
and run samples from [Go](https://github.com/temporalio/samples-go) and [Java](https://github.com/temporalio/samples-java) samples repos. Also, you can access web UI at `localhost:8080`.

Expand Down
4 changes: 4 additions & 0 deletions Makefile
Expand Up @@ -135,6 +135,10 @@ update-tctl:
@printf $(COLOR) "Install/update tctl..."
@go install github.com/temporalio/tctl/cmd/tctl@latest

update-cli:
@printf $(COLOR) "Install/update cli..."
curl -sSf https://temporal.download/cli.sh | sh

update-ui:
@printf $(COLOR) "Install/update temporal ui-server..."
@go install github.com/temporalio/ui-server/cmd/server@latest
Expand Down

0 comments on commit 31a87d9

Please sign in to comment.