Skip to content

Commit

Permalink
Remove unused HostsUpdated field from ChangedEvent
Browse files Browse the repository at this point in the history
  • Loading branch information
MichaelSnowden committed Mar 6, 2023
1 parent 9740e7f commit 357cc7a
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion common/membership/interfaces.go
Expand Up @@ -53,7 +53,6 @@ type (
// ChangedEvent describes a change in membership
ChangedEvent struct {
HostsAdded []HostInfo
HostsUpdated []HostInfo
HostsRemoved []HostInfo
}

Expand Down
4 changes: 0 additions & 4 deletions common/membership/ringpop/monitor_test.go
Expand Up @@ -80,7 +80,6 @@ func (s *RpoSuite) TestMonitor() {
s.Equal(1, len(e.HostsRemoved), "ringpop monitor event does not report the removed host")
s.Equal(testService.hostAddrs[1], e.HostsRemoved[0].GetAddress(), "ringpop monitor reported that a wrong host was removed")
s.Nil(e.HostsAdded, "Unexpected host reported to be added by ringpop monitor")
s.Nil(e.HostsUpdated, "Unexpected host reported to be updated by ringpop monitor")
case <-time.After(time.Minute):
s.Fail("Timed out waiting for failure to be detected by ringpop")
}
Expand Down Expand Up @@ -123,9 +122,6 @@ func (s *RpoSuite) verifyMemberDiff(curr []string, new []string, expectedDiff []
for _, a := range event.HostsAdded {
diff = append(diff, "+"+a.GetAddress())
}
for _, a := range event.HostsUpdated {
diff = append(diff, "~"+a.GetAddress())
}
for _, a := range event.HostsRemoved {
diff = append(diff, "-"+a.GetAddress())
}
Expand Down
2 changes: 1 addition & 1 deletion service/history/shard/controller_impl.go
Expand Up @@ -368,7 +368,7 @@ func (c *ControllerImpl) shardManagementPump() {
c.contextTaggedLogger.Info("", tag.ValueRingMembershipChangedEvent,
tag.NumberProcessed(len(changedEvent.HostsAdded)),
tag.NumberDeleted(len(changedEvent.HostsRemoved)),
tag.Number(int64(len(changedEvent.HostsUpdated))))
)
c.acquireShards()
}
}
Expand Down

0 comments on commit 357cc7a

Please sign in to comment.