Disable revive.unexported-return linter (#4466)

temporalio · Jun 14, 2023 · 363e92c · 363e92c
1 parent a24557b
commit 363e92c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -59,14 +59,16 @@ linters-settings:
         disabled: true
       - name: unexported-naming
         disabled: true
+      - name: unexported-return
+        disabled: true
+      - name: unused-parameter
+        disabled: true
       - name: unused-receiver
         disabled: true
       - name: use-any
         disabled: true
       - name: var-naming
         disabled: true
-      - name: unused-parameter
-        disabled: true
 
       # Rule tuning
       - name: argument-limit

diff --git a/service/history/workflow/update/export_test.go b/service/history/workflow/update/export_test.go
@@ -34,8 +34,6 @@ var (
 )
 
 // ObserveCompletion exporses withOnComplete to unit tests
-//
-//revive:disable-next-line:unexported-return for testing
 func ObserveCompletion(b *bool) updateOpt {
 	return withCompletionCallback(func() { *b = true })
 }
diff --git a/service/history/workflow/update/registry.go b/service/history/workflow/update/registry.go
@@ -92,8 +92,6 @@ type (
 	regOpt func(*RegistryImpl)
 )
 
-//revive:disable:unexported-return I *want* it to be unexported
-
 // WithInFlightLimit provides an optional limit to the number of incomplete
 // updates that a Registry instance will allow.
 func WithInFlightLimit(f func() int) regOpt {
@@ -133,8 +131,6 @@ func WithTracerProvider(t trace.TracerProvider) regOpt {
 	}
 }
 
-//revive:enable:unexported-return
-
 var _ Registry = (*RegistryImpl)(nil)
 
 func NewRegistry(store UpdateStore, opts ...regOpt) *RegistryImpl {