Skip to content

Commit

Permalink
Restore defaultListWorkflowsPageSize back to 1000 (from 100) (#4674)
Browse files Browse the repository at this point in the history
<!-- Describe what has changed in this PR -->
**What changed?**


<!-- Tell your future self why have you made these changes -->
**Why?**
GenerateReplicationTasks and VerifyReplicationTasks runs in parallel.
VerifyReplicationTasks runs every 2s. Verification is not instantaneous,
which means for every batch, Verification can delay at least 5s.
Increase batch size, reduce the ration of the delay in batch processing.
Before the change, RPS for GenerateReplicationTasks +
VerifyReplicationTasks is 30 RPS. With the change RPS is 90.

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
Cluster test. 

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**


<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
Yes.
  • Loading branch information
hehaifengcn authored and mindaugasrukas committed Jul 24, 2023
1 parent 91a3146 commit 55c4d36
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion service/worker/migration/force_replication_workflow.go
Expand Up @@ -133,7 +133,7 @@ const (
taskQueueUserDataReplicationDoneSignalType = "task-queue-user-data-replication-done"
taskQueueUserDataReplicationVersionMarker = "replicate-task-queue-user-data"

defaultListWorkflowsPageSize = 100
defaultListWorkflowsPageSize = 1000
defaultPageCountPerExecution = 200
maxPageCountPerExecution = 1000
defaultPageSizeForTaskQueueUserDataReplication = 20
Expand Down

0 comments on commit 55c4d36

Please sign in to comment.