Don't change task generator constructor

common/archiver/archivalMetadata.go

@@ -234,3 +234,7 @@ func getNamespaceArchivalState(str string) (enumspb.ArchivalState, error) {
 	}
 	return enumspb.ARCHIVAL_STATE_DISABLED, fmt.Errorf("invalid archival state of %v for namespace, valid states are: {\"\", \"disabled\", \"enabled\"}", str)
 }
+
+func NewDisabledArchivalMetadata() ArchivalMetadata {
+	return &archivalMetadata{historyConfig: NewDisabledArchvialConfig(), visibilityConfig: NewDisabledArchvialConfig()}
+}

service/history/archival_queue_task_executor.go

@@ -246,7 +246,7 @@ func (e *archivalQueueTaskExecutor) addDeletionTask(
 		e.shardContext.GetNamespaceRegistry(),
 		mutableState,
 		e.shardContext.GetConfig(),
-		e.shardContext.GetArchivalMetadata(),
+		workflow.WithArchivalMetadata(e.shardContext.GetArchivalMetadata()),
 	)
 	err = taskGenerator.GenerateDeleteHistoryEventTask(*closeTime, true)
 	if err != nil {

service/history/workflow/task_generator.go

@@ -117,17 +117,31 @@ const defaultWorkflowRetention = 1 * 24 * time.Hour
 
 var _ TaskGenerator = (*TaskGeneratorImpl)(nil)
 
+type TaskGeneratorOption func(*TaskGeneratorImpl)
+
 func NewTaskGenerator(
 	namespaceRegistry namespace.Registry,
 	mutableState MutableState,
 	config *configs.Config,
-	archivalMetadata archiver.ArchivalMetadata,
+	opts ...TaskGeneratorOption,
 ) *TaskGeneratorImpl {
-	return &TaskGeneratorImpl{
+	r := &TaskGeneratorImpl{
 		namespaceRegistry: namespaceRegistry,
 		mutableState:      mutableState,
 		config:            config,
-		archivalMetadata:  archivalMetadata,
+		archivalMetadata:  archiver.NewDisabledArchivalMetadata(),
+	}
+	for _, opt := range opts {
+		opt(r)
+	}
+	return r
+}
+
+// WithArchivalMetadata is used to set the archival metadata for the task generator to determine whether to generate
+// archival tasks. The default value is disabled archival metadata.
+func WithArchivalMetadata(metadata archiver.ArchivalMetadata) TaskGeneratorOption {
+	return func(r *TaskGeneratorImpl) {
+		r.archivalMetadata = metadata
 	}
 }
 

service/history/workflow/task_generator_provider.go

@@ -56,6 +56,6 @@ func (p *taskGeneratorProviderImpl) NewTaskGenerator(
 		shard.GetNamespaceRegistry(),
 		mutableState,
 		shard.GetConfig(),
-		shard.GetArchivalMetadata(),
+		WithArchivalMetadata(shard.GetArchivalMetadata()),
 	)
 }

service/history/workflow/task_generator_test.go

@@ -298,7 +298,8 @@ func TestTaskGeneratorImpl_GenerateWorkflowCloseTasks(t *testing.T) {
 				return cfg
 			}).AnyTimes()
 
-			taskGenerator := NewTaskGenerator(namespaceRegistry, mutableState, cfg, archivalMetadata)
+			taskGenerator := NewTaskGenerator(namespaceRegistry, mutableState, cfg,
+				WithArchivalMetadata(archivalMetadata))
 			err := taskGenerator.GenerateWorkflowCloseTasks(&historypb.HistoryEvent{
 				Attributes: &historypb.HistoryEvent_WorkflowExecutionCompletedEventAttributes{
 					WorkflowExecutionCompletedEventAttributes: &historypb.WorkflowExecutionCompletedEventAttributes{},