Skip to content

Commit

Permalink
Rename UpdateWorkflow to UpdateWorkflowExecution (#3832)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexshtin committed Jan 25, 2023
1 parent 4c71899 commit 7e54876
Show file tree
Hide file tree
Showing 31 changed files with 601 additions and 572 deletions.
692 changes: 346 additions & 346 deletions api/historyservice/v1/request_response.pb.go

Large diffs are not rendered by default.

184 changes: 92 additions & 92 deletions api/historyservice/v1/service.pb.go

Large diffs are not rendered by default.

28 changes: 14 additions & 14 deletions api/historyservicemock/v1/service.pb.mock.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions client/frontend/client_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions client/frontend/metric_client_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions client/frontend/retryable_client_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions client/history/client_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions client/history/metric_client_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions client/history/retryable_client_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions common/metrics/metric_defs.go
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,8 @@ const (
DCRedirectionUpdateWorkerBuildIdOrderingScope = "DCRedirectionUpdateWorkerBuildIdOrdering"
// DCRedirectionGetWorkerBuildIdOrderingScope tracks RPC calls for dc redirection
DCRedirectionGetWorkerBuildIdOrderingScope = "DCRedirectionGetWorkerBuildIdOrdering"
// DCRedirectionUpdateWorkflowScope tracks RPC calls for dc redirection
DCRedirectionUpdateWorkflowScope = "DCRedirectionUpdateWorkflow"
// DCRedirectionUpdateWorkflowExecutionScope tracks RPC calls for dc redirection
DCRedirectionUpdateWorkflowExecutionScope = "DCRedirectionUpdateWorkflowExecution"
// DCRedirectionDescribeBatchOperationScope tracks RPC calls for dc redirection
DCRedirectionDescribeBatchOperationScope = "DCRedirectionDescribeBatchOperation"
// DCRedirectionListBatchOperationsScope tracks RPC calls for dc redirection
Expand Down Expand Up @@ -430,8 +430,8 @@ const (
FrontendClientListSchedulesScope = "FrontendClientListSchedules"
// FrontendClientUpdateWorkerBuildIdOrderingScope tracks RPC calls to frontend service
FrontendClientUpdateWorkerBuildIdOrderingScope = "FrontendClientUpdateWorkerBuildIdOrdering"
// FrontendClientUpdateWorkflowScope tracks RPC calls to frontend service
FrontendClientUpdateWorkflowScope = "FrontendClientUpdateWorkflow"
// FrontendClientUpdateWorkflowExecutionScope tracks RPC calls to frontend service
FrontendClientUpdateWorkflowExecutionScope = "FrontendClientUpdateWorkflowExecution"
// FrontendClientGetWorkerBuildIdOrderingScope tracks RPC calls to frontend service
FrontendClientGetWorkerBuildIdOrderingScope = "FrontendClientGetWorkerBuildIdOrdering"
// FrontendClientDescribeBatchOperationScope tracks RPC calls to frontend service
Expand Down Expand Up @@ -482,8 +482,8 @@ const (
HistoryClientRemoveSignalMutableStateScope = "HistoryClientRemoveSignalMutableState"
// HistoryClientTerminateWorkflowExecutionScope tracks RPC calls to history service
HistoryClientTerminateWorkflowExecutionScope = "HistoryClientTerminateWorkflowExecution"
// HistoryClientUpdateWorkflowScope tracks RPC calls to history service
HistoryClientUpdateWorkflowScope = "HistoryClientUpdateWorkflow"
// HistoryClientUpdateWorkflowExecutionScope tracks RPC calls to history service
HistoryClientUpdateWorkflowExecutionScope = "HistoryClientUpdateWorkflowExecution"
// HistoryClientDeleteWorkflowExecutionScope tracks RPC calls to history service
HistoryClientDeleteWorkflowExecutionScope = "HistoryClientDeleteWorkflowExecution"
// HistoryClientResetWorkflowExecutionScope tracks RPC calls to history service
Expand Down Expand Up @@ -921,8 +921,8 @@ const (
FrontendUpdateWorkerBuildIdOrderingScope = "UpdateWorkerBuildIdOrdering"
// FrontendGetWorkerBuildIdOrderingScope is the metric scope for frontend.GetWorkerBuildIdOrderingScope = "GetWorkerBuildIdOrderingScope is the metric scope for frontend.GetWorkerBuildIdOrdering"
FrontendGetWorkerBuildIdOrderingScope = "GetWorkerBuildIdOrdering"
// FrontendUpdateWorkflowScope is the metric scope for frontend.UpdateWorkflow
FrontendUpdateWorkflowScope = "UpdateWorkflow"
// FrontendUpdateWorkflowExecutionScope is the metric scope for frontend.UpdateWorkflowExecution
FrontendUpdateWorkflowExecutionScope = "UpdateWorkflowExecution"
// FrontendDescribeBatchOperationScope is the metric scope for frontend.DescribeBatchOperation
FrontendDescribeBatchOperationScope = "DescribeBatchOperation"
// FrontendListBatchOperationsScope is the metric scope for frontend.ListBatchOperations
Expand Down Expand Up @@ -1021,8 +1021,8 @@ const (
HistoryDescribeHistoryHostScope = "DescribeHistoryHost"
// HistoryDeleteWorkflowVisibilityRecordScope is the scope used by delete workflow visibility record API
HistoryDeleteWorkflowVisibilityRecordScope = "DeleteWorkflowVisibilityRecord"
// HistoryUpdateWorkflowScope is the scope used by update workflow API
HistoryUpdateWorkflowScope = "UpdateWorkflow"
// HistoryUpdateWorkflowExecutionScope is the scope used by update workflow execution API
HistoryUpdateWorkflowExecutionScope = "UpdateWorkflowExecution"
// HistoryResetWorkflowExecutionScope tracks ResetWorkflowExecution API calls received by service
HistoryResetWorkflowExecutionScope = "ResetWorkflowExecution"
// HistoryQueryWorkflowScope tracks QueryWorkflow API calls received by service
Expand Down
2 changes: 1 addition & 1 deletion common/persistence/client/quotas.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ var (
"RequestCancelWorkflowExecution": 0,
"TerminateWorkflowExecution": 0,
"GetWorkflowExecutionHistory": 0,
"UpdateWorkflow": 0,
"UpdateWorkflowExecution": 0,
}

BackgroundTypeAPIPriorityOverride = map[string]int{
Expand Down
8 changes: 4 additions & 4 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ require (
go.opentelemetry.io/otel/metric v0.33.0
go.opentelemetry.io/otel/sdk v1.11.1
go.opentelemetry.io/otel/sdk/metric v0.31.0
go.temporal.io/api v1.14.1-0.20230123181040-6d7a91e07c31
go.temporal.io/sdk v1.20.0
go.temporal.io/api v1.15.1-0.20230125004443-42737e40d339
go.temporal.io/sdk v1.20.1-0.20230125015921-1fe6824cedfe
go.temporal.io/version v0.3.0
go.uber.org/atomic v1.10.0
go.uber.org/fx v1.18.2
Expand All @@ -55,7 +55,7 @@ require (
golang.org/x/oauth2 v0.2.0
golang.org/x/time v0.2.0
google.golang.org/api v0.103.0
google.golang.org/grpc v1.52.0
google.golang.org/grpc v1.52.1
google.golang.org/grpc/examples v0.0.0-20221201195934-736197138d20
gopkg.in/square/go-jose.v2 v2.6.0
gopkg.in/validator.v2 v2.0.1
Expand Down Expand Up @@ -127,7 +127,7 @@ require (
golang.org/x/tools v0.3.0 // indirect
golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 // indirect
google.golang.org/appengine v1.6.7 // indirect
google.golang.org/genproto v0.0.0-20230119192704-9d59e20e5cd1 // indirect
google.golang.org/genproto v0.0.0-20230124163310-31e0e69b6fc2 // indirect
google.golang.org/protobuf v1.28.1 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
lukechampine.com/uint128 v1.2.0 // indirect
Expand Down
18 changes: 8 additions & 10 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -840,11 +840,10 @@ go.opentelemetry.io/otel/trace v1.11.1/go.mod h1:f/Q9G7vzk5u91PhbmKbg1Qn0rzH1LJ4
go.opentelemetry.io/proto/otlp v0.7.0/go.mod h1:PqfVotwruBrMGOCsRd/89rSnXhoiJIqeYNgFYFoEGnI=
go.opentelemetry.io/proto/otlp v0.19.0 h1:IVN6GR+mhC4s5yfcTbmzHYODqvWAp3ZedA2SJPI1Nnw=
go.opentelemetry.io/proto/otlp v0.19.0/go.mod h1:H7XAot3MsfNsj7EXtrA2q5xSNQ10UqI405h3+duxN4U=
go.temporal.io/api v1.14.0/go.mod h1:tfiIwNOKqwboFAyJ6t+Wz0dtZQlydZqlGetFEU1em6o=
go.temporal.io/api v1.14.1-0.20230123181040-6d7a91e07c31 h1:1uSLdXq1HOjzFNzDLJxmEDC63BEBZzm1ugq4Kk3kKsc=
go.temporal.io/api v1.14.1-0.20230123181040-6d7a91e07c31/go.mod h1:iOTECB2ZzJykSBxAyMSqhIluACJgjCWszdN8wPKKjao=
go.temporal.io/sdk v1.20.0 h1:+Omx4azj6NNuq+Qnf4/lrereNLKHKeSvE8AqG2bW4Vg=
go.temporal.io/sdk v1.20.0/go.mod h1:5W9bRe+0aMCiD7vJnYB1co4xMqziUqQuIHsmOAaDWvo=
go.temporal.io/api v1.15.1-0.20230125004443-42737e40d339 h1:7p2abcEmI8MVqPoBt+mbcHm6t+6fUYS3dUEEAFyzloM=
go.temporal.io/api v1.15.1-0.20230125004443-42737e40d339/go.mod h1:dbi2T2T/PVw0jOHF0pdc8XFDFGQoMQeNq7F0ClTKwlU=
go.temporal.io/sdk v1.20.1-0.20230125015921-1fe6824cedfe h1:mlyDvuKMuxCTcEgmeZs+Qd/x69jyT/Jwq1ULhJGfPbU=
go.temporal.io/sdk v1.20.1-0.20230125015921-1fe6824cedfe/go.mod h1:KtPAB/8+lVNm0aP0W5wLCyxXfHoQJbYNfM4+SfVnsJc=
go.temporal.io/version v0.3.0 h1:dMrei9l9NyHt8nG6EB8vAwDLLTwx2SvRyucCSumAiig=
go.temporal.io/version v0.3.0/go.mod h1:UA9S8/1LaKYae6TyD9NaPMJTZb911JcbqghI2CBSP78=
go.uber.org/atomic v1.4.0/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
Expand Down Expand Up @@ -1366,9 +1365,8 @@ google.golang.org/genproto v0.0.0-20221114212237-e4508ebdbee1/go.mod h1:rZS5c/ZV
google.golang.org/genproto v0.0.0-20221117204609-8f9c96812029/go.mod h1:rZS5c/ZVYMaOGBfO68GWtjOw/eLaZM1X6iVtgjZ+EWg=
google.golang.org/genproto v0.0.0-20221118155620-16455021b5e6/go.mod h1:rZS5c/ZVYMaOGBfO68GWtjOw/eLaZM1X6iVtgjZ+EWg=
google.golang.org/genproto v0.0.0-20221201164419-0e50fba7f41c/go.mod h1:rZS5c/ZVYMaOGBfO68GWtjOw/eLaZM1X6iVtgjZ+EWg=
google.golang.org/genproto v0.0.0-20221207170731-23e4bf6bdc37/go.mod h1:RGgjbofJ8xD9Sq1VVhDM1Vok1vRONV+rg+CjzG4SZKM=
google.golang.org/genproto v0.0.0-20230119192704-9d59e20e5cd1 h1:wSjSSQW7LuPdv3m1IrSN33nVxH/kID6OIKy+FMwGB2k=
google.golang.org/genproto v0.0.0-20230119192704-9d59e20e5cd1/go.mod h1:RGgjbofJ8xD9Sq1VVhDM1Vok1vRONV+rg+CjzG4SZKM=
google.golang.org/genproto v0.0.0-20230124163310-31e0e69b6fc2 h1:O97sLx/Xmb/KIZHB/2/BzofxBs5QmmR0LcihPtllmbc=
google.golang.org/genproto v0.0.0-20230124163310-31e0e69b6fc2/go.mod h1:RGgjbofJ8xD9Sq1VVhDM1Vok1vRONV+rg+CjzG4SZKM=
google.golang.org/grpc v1.12.0/go.mod h1:yo6s7OP7yaDglbqo1J04qKzAhqBH6lvTonzMVmEdcZw=
google.golang.org/grpc v1.19.0/go.mod h1:mqu4LbDTu4XGKhr4mRzUsmM4RtVoemTSY81AxZiDr8c=
google.golang.org/grpc v1.20.1/go.mod h1:10oTOabMzJvdu6/UiuZezV6QK5dSlG84ov/aaiqXj38=
Expand Down Expand Up @@ -1407,8 +1405,8 @@ google.golang.org/grpc v1.49.0/go.mod h1:ZgQEeidpAuNRZ8iRrlBKXZQP1ghovWIVhdJRyCD
google.golang.org/grpc v1.50.0/go.mod h1:ZgQEeidpAuNRZ8iRrlBKXZQP1ghovWIVhdJRyCDK+GI=
google.golang.org/grpc v1.50.1/go.mod h1:ZgQEeidpAuNRZ8iRrlBKXZQP1ghovWIVhdJRyCDK+GI=
google.golang.org/grpc v1.51.0/go.mod h1:wgNDFcnuBGmxLKI/qn4T+m5BtEBYXJPvibbUPsAIPww=
google.golang.org/grpc v1.52.0 h1:kd48UiU7EHsV4rnLyOJRuP/Il/UHE7gdDAQ+SZI7nZk=
google.golang.org/grpc v1.52.0/go.mod h1:pu6fVzoFb+NBYNAvQL08ic+lvB2IojljRYuun5vorUY=
google.golang.org/grpc v1.52.1 h1:2NpOPk5g5Xtb0qebIEs7hNIa++PdtZLo2AQUpc1YnSU=
google.golang.org/grpc v1.52.1/go.mod h1:pu6fVzoFb+NBYNAvQL08ic+lvB2IojljRYuun5vorUY=
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.1.0/go.mod h1:6Kw0yEErY5E/yWrBtf03jp27GLLJujG4z/JK95pnjjw=
google.golang.org/grpc/examples v0.0.0-20221201195934-736197138d20 h1:c4fmRt11lwyTYMMEA3IYCZR/xN7FEAJpwvPziaGXugs=
google.golang.org/grpc/examples v0.0.0-20221201195934-736197138d20/go.mod h1:jMMKnsR3nPEOSsgT/Le2GxpknJOBOQms0nWb0JRgeUM=
Expand Down
2 changes: 1 addition & 1 deletion proto/api
Submodule api updated 34 files
+1 −1 Makefile
+2 −2 temporal/api/batch/v1/message.proto
+7 −19 temporal/api/command/v1/message.proto
+2 −2 temporal/api/common/v1/message.proto
+2 −2 temporal/api/enums/v1/batch_operation.proto
+3 −8 temporal/api/enums/v1/command_type.proto
+2 −2 temporal/api/enums/v1/common.proto
+8 −8 temporal/api/enums/v1/event_type.proto
+7 −2 temporal/api/enums/v1/failed_cause.proto
+2 −2 temporal/api/enums/v1/namespace.proto
+2 −2 temporal/api/enums/v1/query.proto
+2 −2 temporal/api/enums/v1/reset.proto
+2 −2 temporal/api/enums/v1/schedule.proto
+2 −2 temporal/api/enums/v1/task_queue.proto
+24 −8 temporal/api/enums/v1/update.proto
+2 −2 temporal/api/enums/v1/workflow.proto
+2 −2 temporal/api/errordetails/v1/message.proto
+2 −2 temporal/api/failure/v1/message.proto
+2 −2 temporal/api/filter/v1/message.proto
+44 −21 temporal/api/history/v1/message.proto
+0 −87 temporal/api/interaction/v1/message.proto
+2 −2 temporal/api/namespace/v1/message.proto
+2 −2 temporal/api/operatorservice/v1/request_response.proto
+2 −2 temporal/api/operatorservice/v1/service.proto
+29 −11 temporal/api/protocol/v1/message.proto
+2 −2 temporal/api/query/v1/message.proto
+2 −2 temporal/api/replication/v1/message.proto
+2 −2 temporal/api/schedule/v1/message.proto
+2 −2 temporal/api/taskqueue/v1/message.proto
+111 −0 temporal/api/update/v1/message.proto
+2 −2 temporal/api/version/v1/message.proto
+2 −2 temporal/api/workflow/v1/message.proto
+45 −30 temporal/api/workflowservice/v1/request_response.proto
+4 −4 temporal/api/workflowservice/v1/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -617,11 +617,11 @@ message DeleteWorkflowVisibilityRecordResponse {

// (-- api-linter: core::0134=disabled
// aip.dev/not-precedent: This service does not follow the update method AIP --)
message UpdateWorkflowRequest {
message UpdateWorkflowExecutionRequest {
string namespace_id = 1;
temporal.api.workflowservice.v1.UpdateWorkflowRequest request = 2;
temporal.api.workflowservice.v1.UpdateWorkflowExecutionRequest request = 2;
}

message UpdateWorkflowResponse {
temporal.api.workflowservice.v1.UpdateWorkflowResponse response = 1;
message UpdateWorkflowExecutionResponse {
temporal.api.workflowservice.v1.UpdateWorkflowExecutionResponse response = 1;
}
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,6 @@ service HistoryService {

// (-- api-linter: core::0134=disabled
// aip.dev/not-precedent: This service does not follow the update method API --)
rpc UpdateWorkflow(UpdateWorkflowRequest) returns (UpdateWorkflowResponse) {
rpc UpdateWorkflowExecution(UpdateWorkflowExecutionRequest) returns (UpdateWorkflowExecutionResponse) {
}
}

0 comments on commit 7e54876

Please sign in to comment.