-
Notifications
You must be signed in to change notification settings - Fork 758
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix 5s delay on sticky queue (#2811)
Sticky worker mark workflows as running on sticky queue. But when sticky worker is gone (gracefully shutdown or forcefully killed), they don't notify server. When new workflow task or query is scheduled, server still dispatch them to the old sticky queue which now has no worker working on and will only result in 5s sticky queue's schedule_to_start timeout. No mater how long after the old sticky worker is gone, there is always that 5s delay. This PR fix that by checking if if there is no inflight poller for the sticky queue, and no poller is seem within 10s. In that case, matching would return a new StickyWorkerUnavailable error and history would retry that by using original task queue.
- Loading branch information
Showing
17 changed files
with
580 additions
and
1,373 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.