Remove UNSPECIFIED failed cause (#2807)

temporalio · May 6, 2022 · a8a4d27 · a8a4d27
1 parent f1dbddc
commit a8a4d27
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/service/history/transferQueueActiveTaskExecutor.go b/service/history/transferQueueActiveTaskExecutor.go
@@ -451,7 +451,8 @@ func (t *transferQueueActiveTaskExecutor) processCancelExecution(
 		case *serviceerror.NamespaceNotFound:
 			failedCause = enumspb.CANCEL_EXTERNAL_WORKFLOW_EXECUTION_FAILED_CAUSE_NAMESPACE_NOT_FOUND
 		default:
-			failedCause = enumspb.CANCEL_EXTERNAL_WORKFLOW_EXECUTION_FAILED_CAUSE_UNSPECIFIED
+			t.logger.Error("Unexpected error type returned from RequestCancelWorkflowExecution API call.", tag.ErrorType(err), tag.Error(err))
+			return err
 		}
 		return t.requestCancelExternalExecutionFailed(
 			ctx,
@@ -571,7 +572,8 @@ func (t *transferQueueActiveTaskExecutor) processSignalExecution(
 		case *serviceerror.NamespaceNotFound:
 			failedCause = enumspb.SIGNAL_EXTERNAL_WORKFLOW_EXECUTION_FAILED_CAUSE_NAMESPACE_NOT_FOUND
 		default:
-			failedCause = enumspb.SIGNAL_EXTERNAL_WORKFLOW_EXECUTION_FAILED_CAUSE_UNSPECIFIED
+			t.logger.Error("Unexpected error type returned from SignalWorkflowExecution API call.", tag.ErrorType(err), tag.Error(err))
+			return err
 		}
 		return t.signalExternalExecutionFailed(
 			ctx,
@@ -739,14 +741,19 @@ func (t *transferQueueActiveTaskExecutor) processStartChildExecution(
 	)
 	if err != nil {
 		t.logger.Debug("Failed to start child workflow execution", tag.Error(err))
+		if common.IsServiceTransientError(err) || common.IsContextDeadlineExceededErr(err) {
+			// for retryable error just return
+			return err
+		}
 		var failedCause enumspb.StartChildWorkflowExecutionFailedCause
 		switch err.(type) {
 		case *serviceerror.WorkflowExecutionAlreadyStarted:
 			failedCause = enumspb.START_CHILD_WORKFLOW_EXECUTION_FAILED_CAUSE_WORKFLOW_ALREADY_EXISTS
 		case *serviceerror.NamespaceNotFound:
 			failedCause = enumspb.START_CHILD_WORKFLOW_EXECUTION_FAILED_CAUSE_NAMESPACE_NOT_FOUND
 		default:
-			failedCause = enumspb.START_CHILD_WORKFLOW_EXECUTION_FAILED_CAUSE_UNSPECIFIED
+			t.logger.Error("Unexpected error type returned from StartWorkflowExecution API call for child workflow.", tag.ErrorType(err), tag.Error(err))
+			return err
 		}
 
 		return t.recordStartChildExecutionFailed(