>=

temporalio · Jul 18, 2023 · b6171a6 · b6171a6
1 parent 9c2b0ee
commit b6171a6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/common/cache/lru.go b/common/cache/lru.go
@@ -275,7 +275,7 @@ func (c *lru) putInternal(key interface{}, value interface{}, allowUpdate bool)
 		return nil, nil
 	}
 	entrySize := getSize(value)
-	if entrySize >= c.maxSize {
+	if entrySize > c.maxSize {
 		return nil, ErrCacheItemTooLarge
 	}
 

diff --git a/common/cache/lru_test.go b/common/cache/lru_test.go
@@ -355,7 +355,7 @@ func TestCache_ItemSizeTooLarge(t *testing.T) {
 	res := cache.Put(uuid.New(), &testEntryWithCacheSize{maxTotalBytes})
 	assert.Equal(t, res, nil)
 
-	res, err := cache.PutIfNotExist(uuid.New(), &testEntryWithCacheSize{maxTotalBytes})
+	res, err := cache.PutIfNotExist(uuid.New(), &testEntryWithCacheSize{maxTotalBytes + 1})
 	assert.Equal(t, err, ErrCacheItemTooLarge)
 	assert.Equal(t, res, nil)