Skip to content

Commit

Permalink
Use public WorkflowNotReady (#2825)
Browse files Browse the repository at this point in the history
Query workflow need similar error, so we moved the WorkflowNotReady from history internal to public.
  • Loading branch information
yiminc committed May 10, 2022
1 parent 99fdfb6 commit be024bf
Show file tree
Hide file tree
Showing 10 changed files with 47 additions and 288 deletions.
225 changes: 32 additions & 193 deletions api/errordetails/v1/message.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions common/serviceerror/convert.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,6 @@ func FromStatus(st *status.Status) error {
case *errordetails.RetryReplicationFailure:
return newRetryReplication(st, errDetails)
}
case codes.FailedPrecondition:
switch errDetails.(type) {
case *errordetails.WorkflowNotReadyFailure:
return newWorkflowNotReady(st)
}
case codes.Unavailable:
switch errDetails.(type) {
case *errordetails.StickyWorkerUnavailableFailure:
Expand Down
70 changes: 0 additions & 70 deletions common/serviceerror/worflow_not_ready.go

This file was deleted.

4 changes: 2 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ require (
go.opentelemetry.io/otel/metric v0.29.0
go.opentelemetry.io/otel/sdk v1.6.3
go.opentelemetry.io/otel/sdk/metric v0.29.0
go.temporal.io/api v1.7.1-0.20220504205736-d21ec94bbedb
go.temporal.io/api v1.7.1-0.20220510045017-9181247f5f2f
go.temporal.io/sdk v1.14.1-0.20220429221638-3a2b86ebed54
go.temporal.io/version v0.3.0
go.uber.org/atomic v1.9.0
Expand Down Expand Up @@ -109,7 +109,7 @@ require (
golang.org/x/tools v0.1.10 // indirect
golang.org/x/xerrors v0.0.0-20220411194840-2f41105eb62f // indirect
google.golang.org/appengine v1.6.7 // indirect
google.golang.org/genproto v0.0.0-20220504150022-98cd25cafc72 // indirect
google.golang.org/genproto v0.0.0-20220505152158-f39f71e6c8f3 // indirect
google.golang.org/protobuf v1.28.0 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
lukechampine.com/uint128 v1.2.0 // indirect
Expand Down

0 comments on commit be024bf

Please sign in to comment.