Skip to content

Commit

Permalink
Change schedules default catchup window to 1 year (#4332)
Browse files Browse the repository at this point in the history
  • Loading branch information
dnr authored and rodrigozhou committed May 12, 2023
1 parent caac9c2 commit c54890d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion service/worker/scheduler/workflow.go
Expand Up @@ -159,7 +159,7 @@ var (
// the workflow so that we can change them without breaking existing executions or having
// to use versioning.
currentTweakablePolicies = tweakablePolicies{
DefaultCatchupWindow: 60 * time.Second,
DefaultCatchupWindow: 365 * 24 * time.Hour,
MinCatchupWindow: 10 * time.Second,
CanceledTerminatedCountAsFailures: false,
AlwaysAppendTimestamp: true,
Expand Down
2 changes: 1 addition & 1 deletion tests/schedule_test.go
Expand Up @@ -251,7 +251,7 @@ func (s *scheduleIntegrationSuite) TestBasics() {
checkSpec(describeResp.Schedule.Spec)

s.Equal(enumspb.SCHEDULE_OVERLAP_POLICY_SKIP, describeResp.Schedule.Policies.OverlapPolicy) // set to default value
s.EqualValues(60, describeResp.Schedule.Policies.CatchupWindow.Seconds()) // set to default value
s.EqualValues(365*24*3600, describeResp.Schedule.Policies.CatchupWindow.Seconds()) // set to default value

s.Equal(schSAValue.Data, describeResp.SearchAttributes.IndexedFields[csa].Data)
s.Equal(schMemo.Data, describeResp.Memo.Fields["schedmemo1"].Data)
Expand Down

0 comments on commit c54890d

Please sign in to comment.