Skip to content

Commit

Permalink
Remove dry run flag and test run from documentation (#1567)
Browse files Browse the repository at this point in the history
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>

Co-authored-by: wxing1292 <wxing1292@users.noreply.github.com>
  • Loading branch information
tsurdilo and wxing1292 committed May 24, 2021
1 parent e153684 commit f355adc
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
1 change: 0 additions & 1 deletion schema/cassandra/README.md
Expand Up @@ -24,7 +24,6 @@ Q: How do I update existing schema ?
* Create a new schema version directory under ./schema/keyspace/versioned/vx.x
* Add a manifest.json
* Add your changes in a cql file
* Update the unit test within ./tools/cassandra/updateTask_test.go `TestDryrun` with your version x.x
* Once you are done with these use the ./temporal-cassandra-tool to update the schema

Q: What's the format of manifest.json
Expand Down
6 changes: 2 additions & 4 deletions tools/cassandra/README.md
Expand Up @@ -40,10 +40,8 @@ See https://www.ecyrd.com/cassandracalculator for an easy way to determine how m
You can only upgrade to a new version after the initial setup done above.

```
./temporal-cassandra-tool -ep 127.0.0.1 -k temporal update-schema -d ./schema/cassandra/temporal/versioned -v x.x -y -- executes a dryrun of upgrade to version x.x
./temporal-cassandra-tool -ep 127.0.0.1 -k temporal update-schema -d ./schema/cassandra/temporal/versioned -v x.x -- actually executes the upgrade to version x.x
./temporal-cassandra-tool -ep 127.0.0.1 -k temporal update-schema -d ./schema/cassandra/temporal/versioned -v x.x -- executes the upgrade to version x.x
./temporal-cassandra-tool -ep 127.0.0.1 -k temporal_visibility update-schema -d ./schema/cassandra/visibility/versioned -v x.x -y -- executes a dryrun of upgrade to version x.x
./temporal-cassandra-tool -ep 127.0.0.1 -k temporal_visibility update-schema -d ./schema/cassandra/visibility/versioned -v x.x -- actually executes the upgrade to version x.x
./temporal-cassandra-tool -ep 127.0.0.1 -k temporal_visibility update-schema -d ./schema/cassandra/visibility/versioned -v x.x -- executes the upgrade to version x.x
```

6 changes: 2 additions & 4 deletions tools/sql/README.md
Expand Up @@ -36,10 +36,8 @@ temporal-sql-tool --ep $SQL_HOST_ADDR -p $port create --plugin mysql --db tempor
You can only upgrade to a new version after the initial setup done above.

```
./temporal-sql-tool --ep $SQL_HOST_ADDR -p $port --plugin mysql --db temporal update-schema -d ./schema/mysql/v57/temporal/versioned -v x.x -y -- executes a dryrun of upgrade to version x.x
./temporal-sql-tool --ep $SQL_HOST_ADDR -p $port --plugin mysql --db temporal update-schema -d ./schema/mysql/v57/temporal/versioned -v x.x -- actually executes the upgrade to version x.x
./temporal-sql-tool --ep $SQL_HOST_ADDR -p $port --plugin mysql --db temporal update-schema -d ./schema/mysql/v57/temporal/versioned -v x.x -- executes the upgrade to version x.x
./temporal-sql-tool --ep $SQL_HOST_ADDR -p $port --plugin mysql --db temporal_visibility update-schema -d ./schema/mysql/v57/visibility/versioned -v x.x -y -- executes a dryrun of upgrade to version x.x
./temporal-sql-tool --ep $SQL_HOST_ADDR -p $port --plugin mysql --db temporal_visibility update-schema -d ./schema/mysql/v57/visibility/versioned -v x.x -- actually executes the upgrade to version x.x
./temporal-sql-tool --ep $SQL_HOST_ADDR -p $port --plugin mysql --db temporal_visibility update-schema -d ./schema/mysql/v57/visibility/versioned -v x.x -- executes the upgrade to version x.x
```

0 comments on commit f355adc

Please sign in to comment.