Log warning only when there is an error in SA size validation (#3443)

Log error only when there is an error in SA size validation
temporalio · Sep 29, 2022 · f84be21 · f84be21
1 parent 70ca71b
commit f84be21
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/service/history/commandChecker.go b/service/history/commandChecker.go
@@ -176,11 +176,18 @@ func (c *workflowSizeChecker) checkIfSearchAttributesSizeExceedsLimit(
 	namespace namespace.Name,
 	commandTypeTag metrics.Tag,
 ) error {
-	c.metricsScope.Tagged(commandTypeTag).RecordDistribution(metrics.SearchAttributesSize, searchAttributes.Size())
-
+	c.metricsScope.Tagged(commandTypeTag).RecordDistribution(
+		metrics.SearchAttributesSize,
+		searchAttributes.Size(),
+	)
 	err := c.searchAttributesValidator.ValidateSize(searchAttributes, namespace.String())
-	c.logger.Warn("Search attributes size exceeds limits. Fail workflow.", tag.Error(err), tag.WorkflowNamespace(namespace.String()))
-
+	if err != nil {
+		c.logger.Warn(
+			"Search attributes size exceeds limits. Fail workflow.",
+			tag.Error(err),
+			tag.WorkflowNamespace(namespace.String()),
+		)
+	}
 	return err
 }