Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle child not started case in record child completed logic #3977

Closed
yycptt opened this issue Feb 21, 2023 · 0 comments · Fixed by #5067
Closed

Handle child not started case in record child completed logic #3977

yycptt opened this issue Feb 21, 2023 · 0 comments · Fixed by #5067
Labels
potential-bug

Comments

@yycptt
Copy link
Member

yycptt commented Feb 21, 2023 •
edited by sync-by-unito bot

Expected Behavior

Parent workflow should always get child completion event when child is completed/failed/timeout/terminated etc. and continue to make progress

Actual Behavior

Parent won't record the completion event and can get stuck if child timedout or get terminated before child started event is recorded in parent's history.

Possible Solution

Create the started event on child completion.
@sync-by-unito sync-by-unito bot closed this as completed Mar 3, 2023
@yiminc yiminc reopened this Mar 3, 2023
@yiminc yiminc mentioned this issue Oct 22, 2023
Open
@pdoerner pdoerner mentioned this issue Nov 2, 2023
Merged
nichtverstehen pushed a commit to nscloud-demo/temporal that referenced this issue Nov 18, 2023
@pdoerner
Record child start event if missing during record child complete (tem…
93c20ef 
…poralio#5067)

<!-- Describe what has changed in this PR -->
**What changed?**
Added new logic to record child workflow started event if it is missing
when record child workflow complete is called.

<!-- Tell your future self why have you made these changes -->
**Why?**
Resolves temporalio#3977

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
New functional test

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
None

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
potential-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Record child start event if missing during record child complete pdoerner/temporal
2 participants
@yycptt @yiminc